To be clear, my proposal isn't that PRs can't take months or years. It's simply that if changes are requested and the developer doesn't respond for several months (so no progress on the ticket at all) then the PR is closed but can be reopened (even by the person who made the PR ideally, if GitHub permissions allow which I think they do) as soon as they start working on it again.
Ideally any closings of PRs in this way would be accompanied by a link to the developer guide explaining that all the dev needs to do to reopen the PR is continue working on it. Vincent Macri (he/him) ________________________________ From: sage-devel@googlegroups.com <sage-devel@googlegroups.com> on behalf of kcrisman <kcris...@gmail.com> Sent: Wednesday, January 22, 2025 8:48:31 AM To: sage-devel <sage-devel@googlegroups.com> Subject: Re: [sage-devel] Policy for closing abandoned PRs [â–³EXTERNAL] This would be a change in (perhaps not official) policy from Trac. Since PRs are separated from issues on GH (which wasn't really the case on Trac), a change might make sense. However, my opinion (for whatever it's worth) is that this is not really necessary, and could lead to useful code being completely abandoned, in practice. There were many instances in the past where partial fixes/new functionality was finished over a period of months and years in precisely this way (and that could still work as long as the original issue has a clear link to the unfinished PR). Maybe the GH UI is just cluttered in general! (I'm aware this may be a minority opinion.) -- You received this message because you are subscribed to the Google Groups "sage-devel" group. To unsubscribe from this group and stop receiving emails from it, send an email to sage-devel+unsubscr...@googlegroups.com<mailto:sage-devel+unsubscr...@googlegroups.com>. To view this discussion visit https://groups.google.com/d/msgid/sage-devel/d2262ac0-a84e-49d1-b6d1-efe28ac27791n%40googlegroups.com<https://groups.google.com/d/msgid/sage-devel/d2262ac0-a84e-49d1-b6d1-efe28ac27791n%40googlegroups.com?utm_medium=email&utm_source=footer>. -- You received this message because you are subscribed to the Google Groups "sage-devel" group. To unsubscribe from this group and stop receiving emails from it, send an email to sage-devel+unsubscr...@googlegroups.com. To view this discussion visit https://groups.google.com/d/msgid/sage-devel/YQXPR01MB565968F6E796B720C91F545FF7E12%40YQXPR01MB5659.CANPRD01.PROD.OUTLOOK.COM.
