That sounds reasonable to me. I have a couple open PRs, one of which originated months ago, but I try to stay current with it. I don't see a problem with closing it with an appropriate tag with the possibility of reopening down the road if they do respond.
Best, Jackson On Tue, Jan 21, 2025 at 3:22 PM Vincent Macri <vincent.ma...@ucalgary.ca> wrote: > Currently the allowed reasons to close PRs (see > https://doc.sagemath.org/html/en/developer/review.html) is if they try > to do too many things, are patch bombs, or aren't sage-specific. We have > some PRs that have been reviewed with changes requested with no response > from the person who proposed the pull request. Do we have a policy for > when to close these PRs? The review guide also says to tag a rejected PR > with one of "r: duplicate", "r: invalid", "r: wontfix", and "r: > worksforme". None of these seem appropriate for closing a PR from an > unresponsive author. > > Open PRs with an unresponsive author clutter up the GitHub UI and can > potentially bury other important PRs. I also think that if new potential > contributors see hundreds of open PRs on the repo, some of them months > old, they may be discouraged from contributing out of fear that any PR > they make won't get merged. > > If we don't have a policy on this already, may I suggest something along > the lines of this: After a PR is reviewed and changes are requested, if > the author does not respond within 4 months (or some other period of > time that sage-devel thinks is appropriate) then the PR may be closed > with the tag "r: no response". The PR may be reopened at a later date if > the author responds. > > -- > Vincent Macri (He/Him) > > -- > You received this message because you are subscribed to the Google Groups > "sage-devel" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to sage-devel+unsubscr...@googlegroups.com. > To view this discussion visit > https://groups.google.com/d/msgid/sage-devel/e1c5735c-553e-4012-ba0d-2cb9ee0d9d83%40ucalgary.ca > . > -- You received this message because you are subscribed to the Google Groups "sage-devel" group. To unsubscribe from this group and stop receiving emails from it, send an email to sage-devel+unsubscr...@googlegroups.com. To view this discussion visit https://groups.google.com/d/msgid/sage-devel/CAGqtwVB6T-R3nYExD%2BgiVh6Q4_nbntdARO2mJM2qn4Zx-2eKdg%40mail.gmail.com.
