implies that "disputed" label is only for a PR that has positive review 
from a reviewer but another still objects it. I think adding "disputed" 
label prematurely is not appropriate. Then who can remove the "disputed" 
label in this case?


That's not how I interpret the policy we have. I think the idea is to first 
use the "needs whatever" labels and when no agreement can be reached, then 
"disputed" can be set. If we had to wait for a "positive review", then 
there would be a race condition of sorts: You'd have to be fast so the 
release manager does not pick the PR up while the positive review label is 
set.

julian

-- 
You received this message because you are subscribed to the Google Groups 
"sage-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to sage-devel+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/sage-devel/382b2819-cec9-43b5-84dd-60ebec608caan%40googlegroups.com.

Reply via email to