vrozov commented on PR #49928: URL: https://github.com/apache/spark/pull/49928#issuecomment-2849746176
@cloud-fan There are two separate issues discussed on the PR. 1. Approach to the testing functionality in different languages (Scala, Java, Python, R, Go). I am fine with whatever approach was agreed by the community. My only ask is to document the approach if it was not documented. At ASF, community takes the priority over code, so if there are any code convention (style, testing, etc), they need to be discussed and documented for the benefit of new community members. 2. Should the test case for `save()` be part of languages other than Scala. IMO, yes, this is why it is part of `R` and it was actually a miss in Scala and Java. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
