vrozov commented on PR #49928: URL: https://github.com/apache/spark/pull/49928#issuecomment-2844998622
@cloud-fan The positive test cases are already covered in the `JavaDataFrameReaderWriterSuite.java`. Please see https://github.com/apache/spark/blob/7019d5e63b7218049bacf3392716bf6faf8f82a1/sql/core/src/test/java/test/org/apache/spark/sql/JavaDataFrameReaderWriterSuite.java#L82, https://github.com/apache/spark/blob/7019d5e63b7218049bacf3392716bf6faf8f82a1/sql/core/src/test/java/test/org/apache/spark/sql/JavaDataFrameReaderWriterSuite.java#L92, https://github.com/apache/spark/blob/7019d5e63b7218049bacf3392716bf6faf8f82a1/sql/core/src/test/java/test/org/apache/spark/sql/JavaDataFrameReaderWriterSuite.java#L144, https://github.com/apache/spark/blob/7019d5e63b7218049bacf3392716bf6faf8f82a1/sql/core/src/test/java/test/org/apache/spark/sql/JavaDataFrameReaderWriterSuite.java#L135, https://github.com/apache/spark/blob/7019d5e63b7218049bacf3392716bf6faf8f82a1/sql/core/src/test/java/test/org/apache/spark/sql/JavaDataFrameReaderWriterSuite.java#L126, https://github.com/apache/spark/blob/7019d5e63b7218049bacf3392716bf6faf8f82a1/sql/core/src/test/java/test/org/apache/spark/sql/JavaDataFrameReaderWriterSuite.java#L153 and if there are more positive basic use cases that are not covered, adding them should be part of a separate PR (as this one handles specific negative case for the basic API). Can you please also confirm >Was the approach to testing discussed on dev list and is documented in the contribution guidelines? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
