vrozov commented on PR #50594:
URL: https://github.com/apache/spark/pull/50594#issuecomment-2836234314

   @mridulm 
   > Actually, I think my formulation above will still have deadlock - though 
for a different reason, sigh.
   
   I don't think that `begin()`/`end()` are supposed to be used as 
   ```
   try {
     begin();
     try {
       expensiveOp();
     } finally {
       end();
     }
   } catch (InterruptedException ex) {
     Thread.currentThread.interrupt();
   }
   ```
   as `end()` would throw `ClosedByInterruptException` in finally and hide 
`InterruptedException`.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to