vrozov commented on code in PR #50594:
URL: https://github.com/apache/spark/pull/50594#discussion_r2064247467
##########
core/src/main/scala/org/apache/spark/util/UninterruptibleThread.scala:
##########
@@ -69,10 +75,22 @@ private[spark] class UninterruptibleThread(
}
uninterruptibleLock.synchronized {
+ uninterruptible = true
+ }
+
+ while (uninterruptibleLock.synchronized {
// Clear the interrupted status if it's set.
shouldInterruptThread = Thread.interrupted() || shouldInterruptThread
Review Comment:
> is Thread.interrupted() a cheap function
Yes, it is. It is as cheap as getting `volatile boolean`.
> Previously we only call it once, but now it's many times.
In the best and most common case scenarios it is called once.
> shall we do it separately after this while loop?
No, we don't want to enter sleep if `interrupted()` was already called.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
