Ngone51 commented on code in PR #50594:
URL: https://github.com/apache/spark/pull/50594#discussion_r2062781253
##########
core/src/main/scala/org/apache/spark/util/UninterruptibleThread.scala:
##########
@@ -69,10 +75,22 @@ private[spark] class UninterruptibleThread(
}
uninterruptibleLock.synchronized {
+ uninterruptible = true
+ }
+
+ while (uninterruptibleLock.synchronized {
// Clear the interrupted status if it's set.
shouldInterruptThread = Thread.interrupted() || shouldInterruptThread
- uninterruptible = true
+ // wait for super.interrupt() to be called
+ !shouldInterruptThread && awaitInterruptThread }) {
Review Comment:
Thanks for the detailed explaination. My concern in another word is, in C,
is it possible that `Thread.interrupted()` could return true before
`super.interrupt()` completes? After taking a look at JDK code, it seems the
interrupt state is also guarded by a lock, so I expect it is not possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
