cloud-fan commented on PR #50594: URL: https://github.com/apache/spark/pull/50594#issuecomment-2833437859
@wangyum I don't think this works. After we determine `needInterrupt` and release the lock, `def runUninterruptibly` may proceed and start to run the function `f`. Then `def interrupt` proceeds and calls `super.interrupt`, the function `f` gets interrupted which is not expected. That's why we need an extra wait in `def runUninterruptibly`, to wait for `super.interrupt` to complete, and then proceed to reset the interrupted stats and run the function `f`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
