cloud-fan commented on code in PR #50408:
URL: https://github.com/apache/spark/pull/50408#discussion_r2034626681
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala:
##########
@@ -689,6 +689,28 @@ class SparkSqlAstBuilder extends AstBuilder {
throw
QueryParsingErrors.createFuncWithBothIfNotExistsAndReplaceError(ctx)
}
+ val containsGeneratedColumn: Option[Boolean] =
Option(ctx.parameters).map { params =>
+ params.colDefinition().asScala.exists { colDefinition =>
+ colDefinition.colDefinitionOption().asScala.exists { option =>
+ Option(option.generationExpression()).isDefined
+ }
+ }
+ }
+ if (containsGeneratedColumn.contains(true)) {
+ throw
QueryParsingErrors.createFuncWithGeneratedColumnsError(ctx.parameters)
+ }
+
+ val containsConstraints: Option[Boolean] = Option(ctx.parameters).map {
params =>
Review Comment:
nit: we can simplify it a bit more
```
Option(ctx.parameters).foreach { params =>
params.colDefinition().asScala.foreach { colDefinition =>
colDefinition.colDefinitionOption().asScala.foreach { option =>
if (option.generationExpression() != null) throw ...
if (option.columnConstraintDefinition() != null) throw ...
}
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
