cloud-fan commented on code in PR #50408:
URL: https://github.com/apache/spark/pull/50408#discussion_r2032719592


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala:
##########
@@ -3869,6 +3868,24 @@ class AstBuilder extends DataTypeAstBuilder
    * DataType parsing
    * 
********************************************************************************************
 */
 
+  override def visitSingleRoutineParamList(
+      ctx: SingleRoutineParamListContext): StructType = withOrigin(ctx) {
+    val schema = createSchema(ctx.colDefinitionList())
+    val fields = for (field <- schema) yield {
+      field.getCurrentDefaultValue() match {

Review Comment:
   shall we add assert here that only comment and default value can be present? 
This is guaranteed by the parser.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to