wengh commented on code in PR #50408:
URL: https://github.com/apache/spark/pull/50408#discussion_r2034080262
##########
sql/api/src/main/scala/org/apache/spark/sql/types/StructField.scala:
##########
@@ -150,10 +150,13 @@ case class StructField(
/**
* Return the default value of this StructField. This is used for storing
the default value of a
* function parameter.
+ *
+ * It is present when the column represents a UDF argument type with a
default
+ * value, such as: CREATE FUNCTION f(arg INT DEFAULT 42) RETURN ....
*/
private[sql] def getDefault(): Option[String] = {
Review Comment:
nvm, renaming seems to break binary compatibility
```
[error] spark-sql-api: Failed binary compatibility check against
org.apache.spark:spark-sql-api_2.13:3.5.0! Found 3 potential problems (filtered
438)
[error] * static method tupled()scala.Function1 in class
org.apache.spark.sql.types.StructField does not have a correspondent in current
version
[error] filter with:
ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.spark.sql.types.StructField.tupled")
[error] * static method curried()scala.Function1 in class
org.apache.spark.sql.types.StructField does not have a correspondent in current
version
[error] filter with:
ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.spark.sql.types.StructField.curried")
[error] * the type hierarchy of object
org.apache.spark.sql.types.StructField is different in current version. Missing
types {scala.runtime.AbstractFunction4}
[error] filter with:
ProblemFilters.exclude[MissingTypesProblem]("org.apache.spark.sql.types.StructField$")
```
https://github.com/wengh/spark/actions/runs/14342436987/job/40204884977#step:13:6211
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
