cloud-fan commented on code in PR #50408:
URL: https://github.com/apache/spark/pull/50408#discussion_r2034501758


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AbstractSqlParser.scala:
##########
@@ -102,6 +103,10 @@ abstract class AbstractSqlParser extends AbstractParser 
with ParserInterface {
     }
   }
 
+  override def parseRoutineParam(sqlText: String): StructType = parse(sqlText) 
{ parser =>
+    astBuilder.visitSingleRoutineParamList(parser.singleRoutineParamList())

Review Comment:
   shall we follow other methods in this file and wrap it with 
`withErrorHandling`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to