cloud-fan commented on code in PR #50197:
URL: https://github.com/apache/spark/pull/50197#discussion_r2022058072
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/ResolveDefaultColumnsUtil.scala:
##########
@@ -284,16 +284,36 @@ object ResolveDefaultColumns extends QueryErrorsBase
throw QueryCompilationErrors.defaultValuesUnresolvedExprError(
statementType, colName, defaultSQL, ex)
}
+ analyze(colName, dataType, parsed, defaultSQL, statementType)
+ }
+
+ def analyze(
+ colName: String,
+ dataType: DataType,
+ defaultValue: DefaultValue,
+ statementType: String): Expression = {
+ Option(defaultValue.getExpression)
+ .flatMap(ExpressionConverter.toV1)
+ .map(expr => analyze(colName, dataType, expr, expr.sql, statementType))
Review Comment:
nit: shall we use `Option(defaultValue.getSql()).getOrElse(expr.sql)`
instead of `expr.sql`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
