cloud-fan commented on code in PR #50197:
URL: https://github.com/apache/spark/pull/50197#discussion_r2006857248
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/FunctionBuilderBase.scala:
##########
@@ -135,10 +135,11 @@ object NamedParametersSupport {
}
private def toInputParameter(param: ProcedureParameter): InputParameter = {
- val defaultValue = Option(param.defaultValueExpression).map { expr =>
- ResolveDefaultColumns.analyze(param.name, param.dataType, expr, "CALL")
+ val defaultValueExpr = Option(param.defaultValue).map { defaultValue =>
+ val sql = ResolveDefaultColumns.generateSQL(defaultValue)
Review Comment:
shall we use the `expression` field if `sql` field is null?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
