aokolnychyi commented on code in PR #50197:
URL: https://github.com/apache/spark/pull/50197#discussion_r2029793712
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/V2ExpressionUtils.scala:
##########
@@ -205,4 +206,171 @@ object V2ExpressionUtils extends SQLConfHelper with
Logging {
None
}
}
+
+ def toCatalyst(expr: V2Expression): Option[Expression] = expr match {
Review Comment:
@cloud-fan, I went for a simpler option and added the conversion to
`V2ExpressionUtils`. I initially thought about a single utility that could do
bi-directional conversion but it probably won't be worth the complexity and the
risk of introducing bugs in such a critical path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
