aokolnychyi commented on code in PR #50197: URL: https://github.com/apache/spark/pull/50197#discussion_r2019224297
########## sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/DefaultValue.java: ########## @@ -0,0 +1,74 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql.connector.catalog; + +import java.util.Objects; +import javax.annotation.Nullable; + +import org.apache.spark.annotation.Evolving; +import org.apache.spark.sql.connector.expressions.Expression; + +@Evolving +public class DefaultValue { + private final String sql; + private final Expression expr; + + public DefaultValue(String sql) { + this(sql, null /* no expression */); + } + + public DefaultValue(Expression expr) { + this(null /* no sql */, expr); + } + + public DefaultValue(String sql, Expression expr) { + if (sql == null && expr == null) { + throw new IllegalArgumentException("SQL and expression can't be both null"); + } + this.sql = sql; + this.expr = expr; + } + + @Nullable + public String getSql() { + return sql; + } + + @Nullable + public Expression getExpression() { Review Comment: I would personally prefer not to have `getXXX`. Unfortunately, `ColumnDefaultValue` already uses this naming and I do plan to make `ColumnDefaultValue` extend `DefaultValue` in the future. Let me know your thoughts. We can of course deprecate `getExpression` and `getSql` in `ColumnDefaultValue` but it may be an overkill given the benefit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
