hvanhovell commented on code in PR #49971:
URL: https://github.com/apache/spark/pull/49971#discussion_r1978166874
##########
sql/connect/common/pom.xml:
##########
@@ -142,8 +218,26 @@
<includes>
<include>org.spark-project.spark:unused</include>
<include>org.apache.tomcat:annotations-api</include>
+ <include>com.google.guava:*</include>
</includes>
</artifactSet>
+ <filters>
+ <filter>
+ <artifact>com.google.guava:guava</artifact>
+ <excludes>
+ <exclude>com/google/thirdparty/**</exclude>
+ </excludes>
+ </filter>
+ </filters>
+ <relocations>
+ <relocation>
+ <pattern>com.google.common</pattern>
+
<shadedPattern>${spark.shade.packageName}.connect.guava</shadedPattern>
Review Comment:
In a follow-up I would like to homogenize the shading for the client and
server and use `org.sparkproject.connect` for everything.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
