vrozov commented on code in PR #49971:
URL: https://github.com/apache/spark/pull/49971#discussion_r1978372773
##########
sql/connect/common/pom.xml:
##########
@@ -142,8 +218,26 @@
<includes>
<include>org.spark-project.spark:unused</include>
<include>org.apache.tomcat:annotations-api</include>
+ <include>com.google.guava:*</include>
</includes>
</artifactSet>
+ <filters>
+ <filter>
+ <artifact>com.google.guava:guava</artifact>
+ <excludes>
+ <exclude>com/google/thirdparty/**</exclude>
+ </excludes>
+ </filter>
+ </filters>
+ <relocations>
+ <relocation>
+ <pattern>com.google.common</pattern>
+
<shadedPattern>${spark.shade.packageName}.connect.guava</shadedPattern>
+ <includes>
+ <include>com.google.common.**</include>
+ </includes>
+ </relocation>
+ </relocations>
Review Comment:
Do you refer to Spark Connect README or something else? Please suggest where
that should be documented.
As PR is already merged, can you open JIRA.
##########
sql/connect/common/pom.xml:
##########
@@ -114,6 +146,50 @@
</extensions>
<outputDirectory>target/scala-${scala.binary.version}/classes</outputDirectory>
<testOutputDirectory>target/scala-${scala.binary.version}/test-classes</testOutputDirectory>
+ <pluginManagement>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-dependency-plugin</artifactId>
+ <configuration>
Review Comment:
yes
##########
sql/connect/common/pom.xml:
##########
@@ -39,53 +39,85 @@
<artifactId>spark-sql-api_${scala.binary.version}</artifactId>
<version>${project.version}</version>
</dependency>
+ <dependency>
Review Comment:
It is the best practice to specify *used* dependencies explicitly and not to
rely on transitive dependencies. This is what `dependency:analyze` warns about.
By *used* I mean that the package explicitly imports or refers to classes in a
dependency package/library/jar.
##########
sql/connect/common/pom.xml:
##########
@@ -142,8 +218,26 @@
<includes>
<include>org.spark-project.spark:unused</include>
<include>org.apache.tomcat:annotations-api</include>
+ <include>com.google.guava:*</include>
</includes>
</artifactSet>
+ <filters>
+ <filter>
+ <artifact>com.google.guava:guava</artifact>
+ <excludes>
+ <exclude>com/google/thirdparty/**</exclude>
+ </excludes>
+ </filter>
+ </filters>
+ <relocations>
+ <relocation>
+ <pattern>com.google.common</pattern>
+
<shadedPattern>${spark.shade.packageName}.connect.guava</shadedPattern>
Review Comment:
AFAIK, there is no guava shading in the client after this PR and client does
not depend on guava (this is why I removed shading on the client for guava).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
