vrozov commented on code in PR #49971:
URL: https://github.com/apache/spark/pull/49971#discussion_r1978369911
##########
sql/connect/common/pom.xml:
##########
@@ -39,53 +39,85 @@
<artifactId>spark-sql-api_${scala.binary.version}</artifactId>
<version>${project.version}</version>
</dependency>
+ <dependency>
Review Comment:
It is the best practice to specify *used* dependencies explicitly and not to
rely on transitive dependencies. This is what `dependency:analyze` warns about.
By *used* I mean that the module explicitly imports or refers to classes in a
dependency package/library/jar.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
