hvanhovell commented on code in PR #50023: URL: https://github.com/apache/spark/pull/50023#discussion_r1970791525
########## sql/core/src/test/scala/org/apache/spark/sql/DatasetSuite.scala: ########## Review Comment: I think most of these test cases could also be tested in ExpressionEncoderSuite. For example for the nullability tests we should just check if the schema produced by the agnostic encoder is the same as the schema produced by the expression encoder. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
