hvanhovell commented on code in PR #50023:
URL: https://github.com/apache/spark/pull/50023#discussion_r1970705482
##########
sql/core/src/test/scala/org/apache/spark/sql/DatasetSuite.scala:
##########
@@ -2804,6 +2808,21 @@ class DatasetSuite extends QueryTest
}
}
+ test("SPARK-49960: joinWith custom encoder") {
+ /*
+ test based on "joinWith class with primitive, toDF"
+ with "custom" encoder. Removing the use of AgnosticExpressionPathEncoder
+ within SerializerBuildHelper and DeserializerBuildHelper will trigger
MatchErrors
+ */
+ val ds1 = Seq(1, 1, 2).toDS()
+ val ds2 = SparkSession.active.createDataset[ClassData](Seq(ClassData("a",
1),
Review Comment:
Nit: use `spark` instead of `SparkSession.active`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
