chris-twiner commented on code in PR #50023:
URL: https://github.com/apache/spark/pull/50023#discussion_r1969966712
##########
sql/api/src/main/scala/org/apache/spark/sql/catalyst/encoders/AgnosticEncoder.scala:
##########
@@ -286,5 +286,6 @@ object AgnosticEncoders {
override def dataType: DataType = transformed.dataType
override def schema: StructType = transformed.schema
override def isStruct: Boolean = transformed.isStruct
+ override def nullable: Boolean = transformed.nullable
Review Comment:
Given this is only for Spark 4 I'd be happier adding nullable as a param,
this would allow signalling to the builders if the codec can handle nulls or
not for the general case. Let me know if that's an option and I'll do a full
suite of testing again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
