hvanhovell commented on code in PR #50023:
URL: https://github.com/apache/spark/pull/50023#discussion_r1970123366
##########
sql/api/src/main/scala/org/apache/spark/sql/catalyst/encoders/AgnosticEncoder.scala:
##########
@@ -286,5 +286,6 @@ object AgnosticEncoders {
override def dataType: DataType = transformed.dataType
override def schema: StructType = transformed.schema
override def isStruct: Boolean = transformed.isStruct
+ override def nullable: Boolean = transformed.nullable
Review Comment:
<del>That also works for me.</del>
Actually having a nullable param is the only correct solution. It is up to
the codec to decide how it deals with nulls.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
