jingz-db commented on code in PR #49488:
URL: https://github.com/apache/spark/pull/49488#discussion_r1949935064


##########
sql/connect/common/src/main/protobuf/spark/connect/relations.proto:
##########
@@ -1031,6 +1033,30 @@ message GroupMap {
 
   // (Optional) The schema for the grouped state.
   optional DataType state_schema = 10;
+
+  // Below fields are only used by TransformWithState
+  // (Optional) TransformWithState related parameters.
+  optional TransformWithStateInfo transformWithStateInfo = 11;
+}
+
+// Event time rule needed for chaining of operator of TransformWithState

Review Comment:
   > It is really not needed to make the logical representation of Spark 
Connect and the logical representation of Catalyst to be same.
   
   I see. I thought it is encouraged to have the same logical plan but if this 
is not required, then it makes sense to remove it from client protocol. I'll 
move this into connect server in my next commit.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to