> On Jan. 13, 2016, 9:03 p.m., Benjamin Hindman wrote: > > src/slave/container_loggers/rotating.cpp, lines 148-151 > > <https://reviews.apache.org/r/41783/diff/5/?file=1196238#file1196238line148> > > > > Why not do this in the constructor and then no need for the `if > > (process.get() != NULL) {` everywhere?
Do you mean to remove the not-initialized and double-initialize checks? Note: The already committed Sandbox ContainerLogger also does this. As well as the oversubscription modules. - Joseph ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41783/#review114410 ----------------------------------------------------------- On Jan. 13, 2016, 6:12 p.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41783/ > ----------------------------------------------------------- > > (Updated Jan. 13, 2016, 6:12 p.m.) > > > Review request for mesos, Benjamin Hindman and Artem Harutyunyan. > > > Bugs: MESOS-4136 > https://issues.apache.org/jira/browse/MESOS-4136 > > > Repository: mesos > > > Description > ------- > > Adds a non-default ContainerLogger that constrains total log size by rotating > logs (i.e. renaming the head log file). > > > Diffs > ----- > > src/slave/container_loggers/rotate.hpp PRE-CREATION > src/slave/container_loggers/rotate.cpp PRE-CREATION > src/slave/container_loggers/rotating.hpp PRE-CREATION > src/slave/container_loggers/rotating.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/41783/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Joseph Wu > >
