> On Jan. 13, 2016, 11:25 a.m., Benjamin Hindman wrote: > >
Note: I'm still gathering feedback regarding the naming scheme of the rotated logs. > On Jan. 13, 2016, 11:25 a.m., Benjamin Hindman wrote: > > src/slave/container_loggers/rotate.hpp, line 54 > > <https://reviews.apache.org/r/41783/diff/3/?file=1182155#file1182155line54> > > > > How about s/of log/of rotated log/ here? > > > > Also, is 'head' better than 'current'? Just a suggestion, given that > > head sounds like "first", I thought by head you meant the oldest log file, > > not the newest. "Current" doesn't fit very well in some comments, so I renamed to "Leading" instead. (And renamed some variables.) > On Jan. 13, 2016, 11:25 a.m., Benjamin Hindman wrote: > > src/slave/container_loggers/rotate.cpp, lines 35-37 > > <https://reviews.apache.org/r/41783/diff/3/?file=1182156#file1182156line35> > > > > These pulled out? Yup, done in diff#4. - Joseph ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41783/#review113378 ----------------------------------------------------------- On Jan. 13, 2016, 6:12 p.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41783/ > ----------------------------------------------------------- > > (Updated Jan. 13, 2016, 6:12 p.m.) > > > Review request for mesos, Benjamin Hindman and Artem Harutyunyan. > > > Bugs: MESOS-4136 > https://issues.apache.org/jira/browse/MESOS-4136 > > > Repository: mesos > > > Description > ------- > > Adds a non-default ContainerLogger that constrains total log size by rotating > logs (i.e. renaming the head log file). > > > Diffs > ----- > > src/slave/container_loggers/rotate.hpp PRE-CREATION > src/slave/container_loggers/rotate.cpp PRE-CREATION > src/slave/container_loggers/rotating.hpp PRE-CREATION > src/slave/container_loggers/rotating.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/41783/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Joseph Wu > >
