> On Jan. 4, 2016, 10:30 p.m., Mesos ReviewBot wrote: > > Bad patch! > > > > Reviews applied: [41002, 41003, 41004, 41061, 41111, 41166, 41167, 41169, > > 41560, 41294, 41370, 41378, 41779] > > > > Failed command: ./support/apply-review.sh -n -r 41779 > > > > Error: > > 2016-01-05 06:30:37 URL:https://reviews.apache.org/r/41779/diff/raw/ > > [3222/3222] -> "41779.patch" [1] > > Total errors found: 0 > > Checking 2 files > > Error: Commit message summary (the first line) must not exceed 72 > > characters.
Shortened a couple of summary messages (3 of them were over 72 characters :). - Joseph ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41783/#review112778 ----------------------------------------------------------- On Jan. 4, 2016, 6:21 p.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41783/ > ----------------------------------------------------------- > > (Updated Jan. 4, 2016, 6:21 p.m.) > > > Review request for mesos, Benjamin Hindman and Artem Harutyunyan. > > > Bugs: MESOS-4136 > https://issues.apache.org/jira/browse/MESOS-4136 > > > Repository: mesos > > > Description > ------- > > Adds a non-default ContainerLogger that constrains total log size by rotating > logs (i.e. renaming the head log file). > > > Diffs > ----- > > src/slave/container_loggers/rotate.hpp PRE-CREATION > src/slave/container_loggers/rotate.cpp PRE-CREATION > src/slave/container_loggers/rotating.hpp PRE-CREATION > src/slave/container_loggers/rotating.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/41783/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Joseph Wu > >
