-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41783/
-----------------------------------------------------------
(Updated Jan. 23, 2016, 1:07 a.m.)
Review request for mesos, Benjamin Hindman and Artem Harutyunyan.
Changes
-------
Cleaned up some headers.
Refactored `logrotate.cpp` a little (BenH's suggestions).
Added quotation marks inside the `logrotate` command and configuration file.
Added a `setsid` call such that the logger subprocess will not exit if the
agent terminates.
Bugs: MESOS-4136
https://issues.apache.org/jira/browse/MESOS-4136
Repository: mesos
Description
-------
Adds a non-default ContainerLogger that constrains total log size by rotating
logs (i.e. renaming the head log file).
Diffs (updated)
-----
src/slave/container_loggers/lib_logrotate.hpp PRE-CREATION
src/slave/container_loggers/lib_logrotate.cpp PRE-CREATION
src/slave/container_loggers/logrotate.hpp PRE-CREATION
src/slave/container_loggers/logrotate.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/41783/diff/
Testing
-------
make check
Thanks,
Joseph Wu