> On Dec. 29, 2015, 2:34 p.m., Timothy Chen wrote: > > src/slave/container_loggers/rotate.cpp, line 115 > > <https://reviews.apache.org/r/41783/diff/1/?file=1177605#file1177605line115> > > > > Are you expecting termination sent as a empty pipe from stdin here?
Yeah, closing the input pipe is the our current solution for shutting down the logger process along with the task/executor. Other solutions would be messier. For the Mesos Containerizer, we would need to track all these extra processes along with the task/executor. For the Docker Containerizer, we would need to `docker exec` the subprocess (or spawn them in separate containers and track them there). > On Dec. 29, 2015, 2:34 p.m., Timothy Chen wrote: > > src/slave/container_loggers/rotate.cpp, line 125 > > <https://reviews.apache.org/r/41783/diff/1/?file=1177605#file1177605line125> > > > > I think maxFiles shouldn't be zero as well right? We will then not > > remove the oldest log file. Right. There are actually a few places we can check these parameters; either inside the logger executable, the logger module, or both. We presumably want at least 1 log file. And each log file should be at least some multiple of the page size (`sysconf(_SC_PAGE_SIZE)`). - Joseph ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41783/#review112231 ----------------------------------------------------------- On Dec. 29, 2015, 2:18 p.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41783/ > ----------------------------------------------------------- > > (Updated Dec. 29, 2015, 2:18 p.m.) > > > Review request for mesos, Benjamin Hindman and Artem Harutyunyan. > > > Bugs: MESOS-4136 > https://issues.apache.org/jira/browse/MESOS-4136 > > > Repository: mesos > > > Description > ------- > > Adds a non-default ContainerLogger that constrains total log size by rotating > logs (i.e. renaming the head log file). > > > Diffs > ----- > > src/slave/container_loggers/rotate.cpp PRE-CREATION > src/slave/container_loggers/rotating.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/41783/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Joseph Wu > >
