Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/20710 )
Change subject: IMPALA-12471: Add unit tests of external jdbc tables for MySQL ...................................................................... Patch Set 8: (9 comments) http://gerrit.cloudera.org:8080/#/c/20710/8/testdata/bin/create-ext-mysql-data-source-table.sql File testdata/bin/create-ext-mysql-data-source-table.sql: http://gerrit.cloudera.org:8080/#/c/20710/8/testdata/bin/create-ext-mysql-data-source-table.sql@1 PS8, Line 1: -- this file is not needed since the data source and tables will be created in mysql-ext-jdbc-tables.test http://gerrit.cloudera.org:8080/#/c/20710/8/testdata/bin/setup-mysql-env.sh File testdata/bin/setup-mysql-env.sh: http://gerrit.cloudera.org:8080/#/c/20710/8/testdata/bin/setup-mysql-env.sh@36 PS8, Line 36: then nit: put 'then' in the same line as 'if' http://gerrit.cloudera.org:8080/#/c/20710/8/testdata/bin/setup-mysql-env.sh@45 PS8, Line 45: then same as previous comment http://gerrit.cloudera.org:8080/#/c/20710/8/testdata/bin/setup-mysql-env.sh@47 PS8, Line 47: nit: extra space http://gerrit.cloudera.org:8080/#/c/20710/8/testdata/bin/setup-mysql-env.sh@88 PS8, Line 88: with_quote nit: change to case_sensitive http://gerrit.cloudera.org:8080/#/c/20710/8/testdata/bin/setup-mysql-env.sh@89 PS8, Line 89: AllTypesWithQuote change to AllTypesCaseSensitiveNames http://gerrit.cloudera.org:8080/#/c/20710/8/testdata/bin/setup-mysql-env.sh@107 PS8, Line 107: with_quote nit: change to case_sensitive http://gerrit.cloudera.org:8080/#/c/20710/8/testdata/bin/setup-mysql-env.sh@128 PS8, Line 128: cd use 'pushd'/'popd' instead of 'cd' so that current directory could be restored. http://gerrit.cloudera.org:8080/#/c/20710/8/testdata/bin/setup-mysql-env.sh@139 PS8, Line 139: # Create data source tables (alltypes_jdbc_datasource and : # alltypes_jdbc_datasource_2). : ${IMPALA_HOME}/bin/impala-shell.sh -f\ : ${IMPALA_HOME}/testdata/bin/create-ext-mysql-data-source-table.sql this is not needed since the data source and tables will be created in test file. -- To view, visit http://gerrit.cloudera.org:8080/20710 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I446ec3d4ebaf53c8edac0b2d181514bde587dfae Gerrit-Change-Number: 20710 Gerrit-PatchSet: 8 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Tue, 21 Nov 2023 22:50:14 +0000 Gerrit-HasComments: Yes
