Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/20710 )
Change subject: IMPALA-12471: Add unit tests of external jdbc tables for MySQL ...................................................................... Patch Set 10: (7 comments) Some minor nits http://gerrit.cloudera.org:8080/#/c/20710/10/testdata/bin/clean-mysql-env.sh File testdata/bin/clean-mysql-env.sh: http://gerrit.cloudera.org:8080/#/c/20710/10/testdata/bin/clean-mysql-env.sh@42 PS10, Line 42: Impala nit: mysql http://gerrit.cloudera.org:8080/#/c/20710/10/testdata/bin/setup-mysql-env.sh File testdata/bin/setup-mysql-env.sh: http://gerrit.cloudera.org:8080/#/c/20710/10/testdata/bin/setup-mysql-env.sh@59 PS10, Line 59: if exists functional;\ nit: it's better to keep the indent spaces. http://gerrit.cloudera.org:8080/#/c/20710/10/testdata/bin/setup-mysql-env.sh@87 PS10, Line 87: /tmp/mysql_jdbc_alltypes.sql nit: it's better to keep the indent spaces. http://gerrit.cloudera.org:8080/#/c/20710/10/testdata/bin/setup-mysql-env.sh@108 PS10, Line 108: /tmp/mysql_jdbc_alltypes_with_case_sensitive_names.sql nit: it's better to keep the indent spaces. http://gerrit.cloudera.org:8080/#/c/20710/10/testdata/bin/setup-mysql-env.sh@129 PS10, Line 129: && wget "https://downloads.mysql.com/archives/get/p/3/file/\ nit: break as two lines http://gerrit.cloudera.org:8080/#/c/20710/10/testdata/bin/setup-mysql-env.sh@134 PS10, Line 134: /tmp/mysql-connector-j-8.1.0/mysql-connector-j-8.1.0.jar \ nit: it's better to keep the indent spaces. http://gerrit.cloudera.org:8080/#/c/20710/10/testdata/bin/setup-mysql-env.sh@137 PS10, Line 137: fe/target/dependency/ nit: correct path -- To view, visit http://gerrit.cloudera.org:8080/20710 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I446ec3d4ebaf53c8edac0b2d181514bde587dfae Gerrit-Change-Number: 20710 Gerrit-PatchSet: 10 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Tue, 28 Nov 2023 21:06:27 +0000 Gerrit-HasComments: Yes
