Arnab Karmakar has posted comments on this change. ( http://gerrit.cloudera.org:8080/23804 )
Change subject: IMPALA-13863: Add metric to track number of loaded tables in catalogd ...................................................................... Patch Set 7: (4 comments) http://gerrit.cloudera.org:8080/#/c/23804/6/tests/custom_cluster/test_automatic_invalidation.py File tests/custom_cluster/test_automatic_invalidation.py: http://gerrit.cloudera.org:8080/#/c/23804/6/tests/custom_cluster/test_automatic_invalidation.py@116 PS6, Line 116: e_query("invalidat > INVALIDATE is not async. Please remove misleading comments like this. Done, but you taught this in the slide: https://docs.google.com/presentation/d/1BNI4wVABcKzj14Lu3XqgI-oV2LbBdmZzUEBIQ1k0B_M/edit?slide=id.g3093a991b01_0_65#slide=id.g3093a991b01_0_65 Or is it because we are using self.execute_query() that makes it a blocking call. http://gerrit.cloudera.org:8080/#/c/23804/6/tests/custom_cluster/test_automatic_invalidation.py@117 PS6, Line 117: catalogd.wait_for_metric_valu > nit: create a variable to make this shorter, e.g. catalogd = self.cluster.c Done http://gerrit.cloudera.org:8080/#/c/23804/6/tests/custom_cluster/test_automatic_invalidation.py@118 PS6, Line 118: : self.execute_query(self.query) : catalogd.wait_for_metric_value(metric_name, 1, timeout=10) : > Remove assertions like these since wait_for_metric_value() has the assertio Done http://gerrit.cloudera.org:8080/#/c/23804/6/tests/custom_cluster/test_automatic_invalidation.py@124 PS6, Line 124: it_for_metric_value(metr > Background table loading is done as the first step in executing the query. Done -- To view, visit http://gerrit.cloudera.org:8080/23804 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5aa54f9f7507709b654df22e24592799811e8b6c Gerrit-Change-Number: 23804 Gerrit-PatchSet: 7 Gerrit-Owner: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Tue, 30 Dec 2025 04:56:36 +0000 Gerrit-HasComments: Yes
