Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/23804 )
Change subject: IMPALA-13863: Add metric to track number of loaded tables in catalogd ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/23804/4/tests/custom_cluster/test_automatic_invalidation.py File tests/custom_cluster/test_automatic_invalidation.py: http://gerrit.cloudera.org:8080/#/c/23804/4/tests/custom_cluster/test_automatic_invalidation.py@271 PS4, Line 271: : count_after_t > Honestly Im also a little puzzled, I removed the sleep() and its working no I just realized the metrics are refreshed every second: https://github.com/apache/impala/blob/1970cc709df637f1e416198fb9a6553b2947bffa/be/src/catalog/catalog-server.cc#L1104 Please replace these sleeps with wait_for_metric_value(): https://github.com/apache/impala/blob/1970cc709df637f1e416198fb9a6553b2947bffa/tests/common/impala_service.py#L133 -- To view, visit http://gerrit.cloudera.org:8080/23804 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5aa54f9f7507709b654df22e24592799811e8b6c Gerrit-Change-Number: 23804 Gerrit-PatchSet: 5 Gerrit-Owner: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Mon, 29 Dec 2025 16:01:46 +0000 Gerrit-HasComments: Yes
