Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/23804 )
Change subject: IMPALA-13863: Add metric to track number of loaded tables in catalogd ...................................................................... Patch Set 6: (4 comments) http://gerrit.cloudera.org:8080/#/c/23804/6/tests/custom_cluster/test_automatic_invalidation.py File tests/custom_cluster/test_automatic_invalidation.py: http://gerrit.cloudera.org:8080/#/c/23804/6/tests/custom_cluster/test_automatic_invalidation.py@116 PS6, Line 116: async invalidation INVALIDATE is not async. Please remove misleading comments like this. http://gerrit.cloudera.org:8080/#/c/23804/6/tests/custom_cluster/test_automatic_invalidation.py@117 PS6, Line 117: self.cluster.catalogd.service nit: create a variable to make this shorter, e.g. catalogd = self.cluster.catalogd.service http://gerrit.cloudera.org:8080/#/c/23804/6/tests/custom_cluster/test_automatic_invalidation.py@118 PS6, Line 118: initial_count = self.cluster.catalogd.service.get_metric_value(metric_name) : assert initial_count is not None, "catalog.num-loaded-tables metric not found" : assert initial_count == 0, ( : "Count should be 0 after global invalidate (got %d)" % initial_count) Remove assertions like these since wait_for_metric_value() has the assertion. http://gerrit.cloudera.org:8080/#/c/23804/6/tests/custom_cluster/test_automatic_invalidation.py@124 PS6, Line 124: background table loading Background table loading is done as the first step in executing the query. -- To view, visit http://gerrit.cloudera.org:8080/23804 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5aa54f9f7507709b654df22e24592799811e8b6c Gerrit-Change-Number: 23804 Gerrit-PatchSet: 6 Gerrit-Owner: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Tue, 30 Dec 2025 01:16:06 +0000 Gerrit-HasComments: Yes
