Arnab Karmakar has posted comments on this change. ( http://gerrit.cloudera.org:8080/23804 )
Change subject: IMPALA-13863: Add metric to track number of loaded tables in catalogd ...................................................................... Patch Set 8: (7 comments) http://gerrit.cloudera.org:8080/#/c/23804/6/tests/custom_cluster/test_automatic_invalidation.py File tests/custom_cluster/test_automatic_invalidation.py: http://gerrit.cloudera.org:8080/#/c/23804/6/tests/custom_cluster/test_automatic_invalidation.py@116 PS6, Line 116: e_query("invalidat > Sorry that if it misleads you. The slide is talking about metadata loading. Thanks for the clarification! Got it, wont share any such links anymore. http://gerrit.cloudera.org:8080/#/c/23804/7/tests/custom_cluster/test_automatic_invalidation.py File tests/custom_cluster/test_automatic_invalidation.py: http://gerrit.cloudera.org:8080/#/c/23804/7/tests/custom_cluster/test_automatic_invalidation.py@117 PS7, Line 117: > nit: Don't need this since the default of timeout is 10. Done http://gerrit.cloudera.org:8080/#/c/23804/7/tests/custom_cluster/test_automatic_invalidation.py@132 PS7, Line 132: # Wait for one metrics refresh cycle (REFRESH_METRICS_INTERVAL_MS) > Here we get the counter without waiting. If the counter changes after 1s (R Done http://gerrit.cloudera.org:8080/#/c/23804/7/tests/custom_cluster/test_automatic_invalidation.py@146 PS7, Line 146: me_tbl rename \ > nit: To be consistent with other code, let's use constant value (e.g. "1" h Done http://gerrit.cloudera.org:8080/#/c/23804/7/tests/custom_cluster/test_automatic_invalidation.py@147 PS7, Line 147: to %s.test_renamed_tbl" % (unique_database, unique_database)) : catalogd.wait_for_metric_value(metric_name, 1) : : # Verify that accessing the renamed table increments the counter : self.execute_query("select * from %s.test_renamed_tbl" % unique_database) : catalogd.wait_for_metric_value(metric_name, 2) > nit: Don't need these since the above wait_for_metric_value() already check Done http://gerrit.cloudera.org:8080/#/c/23804/7/tests/custom_cluster/test_automatic_invalidation.py@167 PS7, Line 167: assert count_after_create == 0, ( > Also need a sleep before this. Done http://gerrit.cloudera.org:8080/#/c/23804/7/tests/custom_cluster/test_automatic_invalidation.py@189 PS7, Line 189: try: : self.execute_query("create database if not exists %s" % test_db) : self.execute_query("create table %s.t1 (id int, name string)" % test_db) : self.execute_query("insert into %s.t1 values (1, 'test')" % test_db) : self.execute_query("select * from %s.t1" % test_db) : catalogd.wait_for_metric_value(metric_name, 1) : finally: : self.execute_query("drop database %s cascade" % test_db) : catalogd.wait_for_metric_value(metric_name, 0) > Wrap the DROP DATABASE statement in the finally clause so it will be droppe Done -- To view, visit http://gerrit.cloudera.org:8080/23804 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5aa54f9f7507709b654df22e24592799811e8b6c Gerrit-Change-Number: 23804 Gerrit-PatchSet: 8 Gerrit-Owner: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Tue, 30 Dec 2025 09:21:12 +0000 Gerrit-HasComments: Yes
