Arnab Karmakar has posted comments on this change. ( http://gerrit.cloudera.org:8080/23804 )
Change subject: IMPALA-13863: Add metric to track number of loaded tables in catalogd ...................................................................... Patch Set 4: (6 comments) http://gerrit.cloudera.org:8080/#/c/23804/3/fe/src/main/java/org/apache/impala/catalog/Db.java File fe/src/main/java/org/apache/impala/catalog/Db.java: http://gerrit.cloudera.org:8080/#/c/23804/3/fe/src/main/java/org/apache/impala/catalog/Db.java@218 PS3, Line 218: * or replaced, allowing the caller to track table state transitions. > New codes added for catalogd could still use this and not update the counte Done, I removed the methods that only take the param tablename and changed all the other call sites of db.addTable()/db.removeTable() to pass the updateFunc. http://gerrit.cloudera.org:8080/#/c/23804/1/tests/custom_cluster/test_automatic_invalidation.py File tests/custom_cluster/test_automatic_invalidation.py: http://gerrit.cloudera.org:8080/#/c/23804/1/tests/custom_cluster/test_automatic_invalidation.py@125 PS1, Line 125: cursor.execute(self.query) > What do you mean by "metric propagation"? Do we check metrics of coordinato My bad, I meant sleeps allow async operations in catalogd to complete like background metadata loading from HMS, event processing from HMS, DDL operations. We then read metrics directly from catalogd, not from coordinators and there are no errors without the sleeps, just the counters dont update yet and we get the old values. http://gerrit.cloudera.org:8080/#/c/23804/1/tests/custom_cluster/test_automatic_invalidation.py@220 PS1, Line 220: cursor.fetchall() > not done yet, please use "0". Done http://gerrit.cloudera.org:8080/#/c/23804/3/tests/custom_cluster/test_automatic_invalidation.py File tests/custom_cluster/test_automatic_invalidation.py: http://gerrit.cloudera.org:8080/#/c/23804/3/tests/custom_cluster/test_automatic_invalidation.py@110 PS3, Line 110: correctly across various metadata operations including loading, invalidation, > It'd be nice to add a test that the loaded table is dropped by processing a Done http://gerrit.cloudera.org:8080/#/c/23804/3/tests/custom_cluster/test_automatic_invalidation.py@126 PS3, Line 126: > nit: using "1" to be simple Done http://gerrit.cloudera.org:8080/#/c/23804/3/tests/custom_cluster/test_automatic_invalidation.py@154 PS3, Line 154: decreases > Let's use 'unique_database' so the whole db will be cleaned up even if the Done -- To view, visit http://gerrit.cloudera.org:8080/23804 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5aa54f9f7507709b654df22e24592799811e8b6c Gerrit-Change-Number: 23804 Gerrit-PatchSet: 4 Gerrit-Owner: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Sun, 28 Dec 2025 19:42:16 +0000 Gerrit-HasComments: Yes
