Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/23799 )
Change subject: IMPALA-13917 (part 2): Close Beeswax port by default ...................................................................... Patch Set 3: Code-Review+1 (12 comments) http://gerrit.cloudera.org:8080/#/c/23799/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23799/1//COMMIT_MSG@15 PS1, Line 15: > Done Done http://gerrit.cloudera.org:8080/#/c/23799/1/be/src/observe/otel-test.cc File be/src/observe/otel-test.cc: http://gerrit.cloudera.org:8080/#/c/23799/1/be/src/observe/otel-test.cc@203 PS1, Line 203: if (FLAGS_beeswax_port > 0) { > Changed to run it if besswax_port is open. Done http://gerrit.cloudera.org:8080/#/c/23799/1/be/src/service/session-expiry-test.cc File be/src/service/session-expiry-test.cc: http://gerrit.cloudera.org:8080/#/c/23799/1/be/src/service/session-expiry-test.cc@83 PS1, Line 83: EXPECT_EQ(beeswax_session_metric->GetValue(), 0L); > IMPALA_SERVER_NUM_OPEN_BEESWAX_SESSIONS does not exist if beeswax_port=0. Ack http://gerrit.cloudera.org:8080/#/c/23799/1/be/src/service/session-expiry-test.cc@123 PS1, Line 123: } > IMPALA_SERVER_NUM_OPEN_BEESWAX_SESSIONS does not exist if beeswax_port=0. Ack http://gerrit.cloudera.org:8080/#/c/23799/1/fe/src/test/java/org/apache/impala/customcluster/LdapImpalaShellTest.java File fe/src/test/java/org/apache/impala/customcluster/LdapImpalaShellTest.java: http://gerrit.cloudera.org:8080/#/c/23799/1/fe/src/test/java/org/apache/impala/customcluster/LdapImpalaShellTest.java@100 PS1, Line 100: protocolsToTest.add("beeswax"); > Done Done http://gerrit.cloudera.org:8080/#/c/23799/1/fe/src/test/java/org/apache/impala/customcluster/LdapKerberosImpalaShellTest.java File fe/src/test/java/org/apache/impala/customcluster/LdapKerberosImpalaShellTest.java: http://gerrit.cloudera.org:8080/#/c/23799/1/fe/src/test/java/org/apache/impala/customcluster/LdapKerberosImpalaShellTest.java@634 PS1, Line 634: } > Done Done http://gerrit.cloudera.org:8080/#/c/23799/1/tests/custom_cluster/test_kudu.py File tests/custom_cluster/test_kudu.py: http://gerrit.cloudera.org:8080/#/c/23799/1/tests/custom_cluster/test_kudu.py@40 PS1, Line 40: for > Done Done http://gerrit.cloudera.org:8080/#/c/23799/1/tests/custom_cluster/test_set_and_unset.py File tests/custom_cluster/test_set_and_unset.py: http://gerrit.cloudera.org:8080/#/c/23799/1/tests/custom_cluster/test_set_and_unset.py@43 PS1, Line 43: validate > Done Done http://gerrit.cloudera.org:8080/#/c/23799/1/tests/custom_cluster/test_set_and_unset.py@43 PS1, Line 43: depr > Done Done http://gerrit.cloudera.org:8080/#/c/23799/1/tests/custom_cluster/test_set_and_unset.py@100 PS1, Line 100: > Done Done http://gerrit.cloudera.org:8080/#/c/23799/1/tests/custom_cluster/test_set_and_unset.py@129 PS1, Line 129: > Done Done http://gerrit.cloudera.org:8080/#/c/23799/1/tests/performance/query_executor.py File tests/performance/query_executor.py: http://gerrit.cloudera.org:8080/#/c/23799/1/tests/performance/query_executor.py@125 PS1, Line 125: plugin_runner=plugin_runner > It is a bug. plugin_runner parameter in __init__ method was unused before t Ack -- To view, visit http://gerrit.cloudera.org:8080/23799 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4f88b0c9799c8d2244fdc1432bd4ace09d6b87dd Gerrit-Change-Number: 23799 Gerrit-PatchSet: 3 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Thu, 18 Dec 2025 22:52:17 +0000 Gerrit-HasComments: Yes
