Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/23799 )
Change subject: IMPALA-13917 (part 2): Close Beeswax port by default ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/23799/1/be/src/service/session-expiry-test.cc File be/src/service/session-expiry-test.cc: http://gerrit.cloudera.org:8080/#/c/23799/1/be/src/service/session-expiry-test.cc@83 PS1, Line 83: EXPECT_EQ(beeswax_session_metric->GetValue(), 0L); > This metric should be 0 even if beeswax is turned off. Thus, I think this IMPALA_SERVER_NUM_OPEN_BEESWAX_SESSIONS does not exist if beeswax_port=0. http://gerrit.cloudera.org:8080/#/c/23799/1/be/src/service/session-expiry-test.cc@123 PS1, Line 123: } > Does it make sense to add an else clause that asserts beeswax_session_metri IMPALA_SERVER_NUM_OPEN_BEESWAX_SESSIONS does not exist if beeswax_port=0. -- To view, visit http://gerrit.cloudera.org:8080/23799 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4f88b0c9799c8d2244fdc1432bd4ace09d6b87dd Gerrit-Change-Number: 23799 Gerrit-PatchSet: 2 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Thu, 18 Dec 2025 22:07:05 +0000 Gerrit-HasComments: Yes
