Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/23799 )
Change subject: IMPALA-13917 (part 2): Close Beeswax port by default ...................................................................... Patch Set 2: (13 comments) http://gerrit.cloudera.org:8080/#/c/23799/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23799/1//COMMIT_MSG@15 PS1, Line 15: start_args. Drop Beeswax option from perf-AB > Please add a brief explanation for this move. Done http://gerrit.cloudera.org:8080/#/c/23799/1/be/src/observe/otel-test.cc File be/src/observe/otel-test.cc: http://gerrit.cloudera.org:8080/#/c/23799/1/be/src/observe/otel-test.cc@203 PS1, Line 203: if (FLAGS_beeswax_port > 0) { > I want to keep this test enabled. Queries submitted over the BEESWAX proto Changed to run it if besswax_port is open. http://gerrit.cloudera.org:8080/#/c/23799/1/bin/start-impala-cluster.py File bin/start-impala-cluster.py: http://gerrit.cloudera.org:8080/#/c/23799/1/bin/start-impala-cluster.py@319 PS1, Line 319: > flake8: W504 line break after binary operator Done http://gerrit.cloudera.org:8080/#/c/23799/1/fe/src/test/java/org/apache/impala/customcluster/LdapImpalaShellTest.java File fe/src/test/java/org/apache/impala/customcluster/LdapImpalaShellTest.java: http://gerrit.cloudera.org:8080/#/c/23799/1/fe/src/test/java/org/apache/impala/customcluster/LdapImpalaShellTest.java@100 PS1, Line 100: protocolsToTest.add("beeswax"); > Should the ENABLE_BEESWAX environment variable be supported here? Done http://gerrit.cloudera.org:8080/#/c/23799/1/fe/src/test/java/org/apache/impala/customcluster/LdapKerberosImpalaShellTest.java File fe/src/test/java/org/apache/impala/customcluster/LdapKerberosImpalaShellTest.java: http://gerrit.cloudera.org:8080/#/c/23799/1/fe/src/test/java/org/apache/impala/customcluster/LdapKerberosImpalaShellTest.java@634 PS1, Line 634: } > Should the ENABLE_BEESWAX environment variable be supported here? Done http://gerrit.cloudera.org:8080/#/c/23799/1/tests/common/impala_cluster.py File tests/common/impala_cluster.py: http://gerrit.cloudera.org:8080/#/c/23799/1/tests/common/impala_cluster.py@658 PS1, Line 658: > flake8: E501 line too long (96 > 90 characters) Done http://gerrit.cloudera.org:8080/#/c/23799/1/tests/common/impala_cluster.py@666 PS1, Line 666: > flake8: E501 line too long (93 > 90 characters) Done http://gerrit.cloudera.org:8080/#/c/23799/1/tests/custom_cluster/test_kudu.py File tests/custom_cluster/test_kudu.py: http://gerrit.cloudera.org:8080/#/c/23799/1/tests/custom_cluster/test_kudu.py@40 PS1, Line 40: for > Nit: "forces" would be a slightly more descriptive word to use here. Done http://gerrit.cloudera.org:8080/#/c/23799/1/tests/custom_cluster/test_set_and_unset.py File tests/custom_cluster/test_set_and_unset.py: http://gerrit.cloudera.org:8080/#/c/23799/1/tests/custom_cluster/test_set_and_unset.py@43 PS1, Line 43: depr > Nit: delete this word since beeswax is already deprecated. Done http://gerrit.cloudera.org:8080/#/c/23799/1/tests/custom_cluster/test_set_and_unset.py@43 PS1, Line 43: validate > Nit: validates Done http://gerrit.cloudera.org:8080/#/c/23799/1/tests/custom_cluster/test_set_and_unset.py@100 PS1, Line 100: > Same comments as line 43. Done http://gerrit.cloudera.org:8080/#/c/23799/1/tests/custom_cluster/test_set_and_unset.py@129 PS1, Line 129: > Same comments as line 43. Done http://gerrit.cloudera.org:8080/#/c/23799/1/tests/performance/query_executor.py File tests/performance/query_executor.py: http://gerrit.cloudera.org:8080/#/c/23799/1/tests/performance/query_executor.py@125 PS1, Line 125: plugin_runner=plugin_runner > Is this a bug fix or was plugin_runner getting set another way? If it's a It is a bug. plugin_runner parameter in __init__ method was unused before this change. But I suspect it always None anyway, so there is no effect (see "--plugin_names" param in bin/run-workload.py). -- To view, visit http://gerrit.cloudera.org:8080/23799 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4f88b0c9799c8d2244fdc1432bd4ace09d6b87dd Gerrit-Change-Number: 23799 Gerrit-PatchSet: 2 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Thu, 18 Dec 2025 21:40:40 +0000 Gerrit-HasComments: Yes
