Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/23799 )
Change subject: IMPALA-13917 (part 2): Close Beeswax port by default ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/23799/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23799/3//COMMIT_MSG@25 PS3, Line 25: - Pass core tests. Did you test that ENABLE_BEESWAX works as expected? http://gerrit.cloudera.org:8080/#/c/23799/3/tests/custom_cluster/test_kill_query.py File tests/custom_cluster/test_kill_query.py: http://gerrit.cloudera.org:8080/#/c/23799/3/tests/custom_cluster/test_kill_query.py@123 PS3, Line 123: @SkipIf.no_beeswax These are custom cluster tests. Let's configure them to start with beeswax enabled instead. Is there a plan to rewrite the tests to use a different protocol? These are relatively recent tests. http://gerrit.cloudera.org:8080/#/c/23799/3/tests/custom_cluster/test_otel_trace.py File tests/custom_cluster/test_otel_trace.py: http://gerrit.cloudera.org:8080/#/c/23799/3/tests/custom_cluster/test_otel_trace.py@84 PS3, Line 84: @SkipIf.no_beeswax This is a custom cluster test, so we could enable beeswax. I'm almost tempted to get rid of the test instead; there's a unit test that covers the same functionality. No strong feelings about changing anything here though. -- To view, visit http://gerrit.cloudera.org:8080/23799 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4f88b0c9799c8d2244fdc1432bd4ace09d6b87dd Gerrit-Change-Number: 23799 Gerrit-PatchSet: 3 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Mon, 05 Jan 2026 19:51:20 +0000 Gerrit-HasComments: Yes
