Zoltan Borok-Nagy has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/23705 )

Change subject: IMPALA-13756: Fix Iceberg V2 count(*) optimization for complex 
queries
......................................................................


Patch Set 4:

(2 comments)

Thanks for the comments!

http://gerrit.cloudera.org:8080/#/c/23705/3//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/23705/3//COMMIT_MSG@69
PS3, Line 69: IcebergV2CountStarAccumula
> nit: should be IcebergV2CountStarAccumulator
Thanks for catching this, done.


http://gerrit.cloudera.org:8080/#/c/23705/3/fe/src/main/java/org/apache/impala/rewrite/CountStarToConstRule.java
File fe/src/main/java/org/apache/impala/rewrite/CountStarToConstRule.java:

http://gerrit.cloudera.org:8080/#/c/23705/3/fe/src/main/java/org/apache/impala/rewrite/CountStarToConstRule.java@56
PS3, Line 56: IcebergV2CountStarAccumula
> nit: should be IcebergV2CountStarAccumulator
Done



--
To view, visit http://gerrit.cloudera.org:8080/23705
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1940031298eb634aa82c3d32bbbf16bce8eaf874
Gerrit-Change-Number: 23705
Gerrit-PatchSet: 4
Gerrit-Owner: Zoltan Borok-Nagy <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Peter Rozsa <[email protected]>
Gerrit-Reviewer: Riza Suminto <[email protected]>
Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
Gerrit-Comment-Date: Wed, 17 Dec 2025 17:32:27 +0000
Gerrit-HasComments: Yes

Reply via email to