Riza Suminto has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/23705 )

Change subject: IMPALA-13756: Fix Iceberg V2 count(*) optimization for complex 
queries
......................................................................


Patch Set 3: Code-Review+1

(3 comments)

http://gerrit.cloudera.org:8080/#/c/23705/2/testdata/workloads/functional-query/queries/QueryTest/iceberg-v2-count-star-optimization-in-complex-query.test
File 
testdata/workloads/functional-query/queries/QueryTest/iceberg-v2-count-star-optimization-in-complex-query.test:

http://gerrit.cloudera.org:8080/#/c/23705/2/testdata/workloads/functional-query/queries/QueryTest/iceberg-v2-count-star-optimization-in-complex-query.test@65
PS2, Line 65: ), table_b as (
            :     SELECT CO
> Done
Done


http://gerrit.cloudera.org:8080/#/c/23705/2/testdata/workloads/functional-query/queries/QueryTest/iceberg-v2-count-star-optimization-in-complex-query.test@101
PS2, Line 101: --                                      this table has 3 rows in 
a data file without deletes, it
             : --
> Contents of the tables should be the same, so diff counts should still be 0
Ack


http://gerrit.cloudera.org:8080/#/c/23705/2/testdata/workloads/functional-query/queries/QueryTest/iceberg-v2-count-star-optimization-in-complex-query.test@103
PS2, Line 103: --    "count(*)": count(*) in view 'diff_count'.
             : with diff_cou
> Done
Done



--
To view, visit http://gerrit.cloudera.org:8080/23705
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1940031298eb634aa82c3d32bbbf16bce8eaf874
Gerrit-Change-Number: 23705
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Riza Suminto <[email protected]>
Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
Gerrit-Comment-Date: Mon, 15 Dec 2025 15:35:31 +0000
Gerrit-HasComments: Yes

Reply via email to