Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/23705 )
Change subject: IMPALA-13756: Fix Iceberg V2 count(*) optimization for complex queries ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/23705/2/common/thrift/Query.thrift File common/thrift/Query.thrift: http://gerrit.cloudera.org:8080/#/c/23705/2/common/thrift/Query.thrift@a991 PS2, Line 991: : : Can this be marked as deprecated instead? Downstream code might relies on this in some way. http://gerrit.cloudera.org:8080/#/c/23705/2/fe/src/main/java/org/apache/impala/analysis/IcebergV2CountStarAdjuster.java File fe/src/main/java/org/apache/impala/analysis/IcebergV2CountStarAdjuster.java: http://gerrit.cloudera.org:8080/#/c/23705/2/fe/src/main/java/org/apache/impala/analysis/IcebergV2CountStarAdjuster.java@20 PS2, Line 20: public class IcebergV2CountStarAdjuster extends ArithmeticExpr { Add documentation about what this expression is about. nit: IcebergV2CountStarAdder or IcebergV2CountStarAccumulator sounds better. -- To view, visit http://gerrit.cloudera.org:8080/23705 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1940031298eb634aa82c3d32bbbf16bce8eaf874 Gerrit-Change-Number: 23705 Gerrit-PatchSet: 2 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Tue, 02 Dec 2025 22:25:42 +0000 Gerrit-HasComments: Yes
