Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/23705 )
Change subject: IMPALA-13756: Fix Iceberg V2 count(*) optimization for complex queries ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/23705/2/testdata/workloads/functional-query/queries/QueryTest/iceberg-v2-count-star-optimization-in-complex-query.test File testdata/workloads/functional-query/queries/QueryTest/iceberg-v2-count-star-optimization-in-complex-query.test: http://gerrit.cloudera.org:8080/#/c/23705/2/testdata/workloads/functional-query/queries/QueryTest/iceberg-v2-count-star-optimization-in-complex-query.test@65 PS2, Line 65: ---- TYPES : BIGINT,BIGINT Add RUNTIME_PROFILE validation? ---- RUNTIME_PROFILE: | output exprs: count(*) - count(*) + CAST(3 AS BIGINT), count(*) http://gerrit.cloudera.org:8080/#/c/23705/2/testdata/workloads/functional-query/queries/QueryTest/iceberg-v2-count-star-optimization-in-complex-query.test@101 PS2, Line 101: ---- RESULTS : 0,0 nit: This result is a bit confusing to me if I compare it against the output exprs. output exprs: count(*) + CAST(1 AS BIGINT) - count(*) + CAST(3 AS BIGINT), count(*) I thought it should result in 4,0. Can you explain what each 'count(*)' values are? http://gerrit.cloudera.org:8080/#/c/23705/2/testdata/workloads/functional-query/queries/QueryTest/iceberg-v2-count-star-optimization-in-complex-query.test@103 PS2, Line 103: ---- TYPES : BIGINT,BIGINT Can validate RUNTIME_PROFILE here, so test case below is not needed. ---- RUNTIME_PROFILE: | output exprs: count(*) + CAST(1 AS BIGINT) - count(*) + CAST(3 AS BIGINT), count(*) -- To view, visit http://gerrit.cloudera.org:8080/23705 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1940031298eb634aa82c3d32bbbf16bce8eaf874 Gerrit-Change-Number: 23705 Gerrit-PatchSet: 2 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Wed, 03 Dec 2025 00:13:12 +0000 Gerrit-HasComments: Yes
