Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/23546 )
Change subject: IMPALA-10204: Make AdmitQuery params more efficient ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/23546/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23546/2//COMMIT_MSG@29 PS2, Line 29: Passed Did we run these tests with admissiond enabled? http://gerrit.cloudera.org:8080/#/c/23546/2/be/src/service/client-request-state.cc File be/src/service/client-request-state.cc: http://gerrit.cloudera.org:8080/#/c/23546/2/be/src/service/client-request-state.cc@669 PS2, Line 669: req = exec_req.query_exec_request; > This will briefly allocate a fair amount of memory? But since it's in the c I think the other option here is to selectively populate TQueryExecRequest with only the required members, but that's likely error prone if we change the thrift structure in future. http://gerrit.cloudera.org:8080/#/c/23546/2/be/src/service/client-request-state.cc@671 PS2, Line 671: std::string().swap(req.query_plan); > Why is this better than I think it's mainly because these don't guarantee releasing underlying container's memory. -- To view, visit http://gerrit.cloudera.org:8080/23546 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1ba5e8818336bd1fc3ad604a0acee5eb7a1116c4 Gerrit-Change-Number: 23546 Gerrit-PatchSet: 2 Gerrit-Owner: Yida Wu <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Wed, 15 Oct 2025 18:18:46 +0000 Gerrit-HasComments: Yes
