Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/23546 )
Change subject: IMPALA-10204: Make AdmitQuery params more efficient ...................................................................... Patch Set 3: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/23546/3/be/src/scheduling/admission-control-service.cc File be/src/scheduling/admission-control-service.cc: http://gerrit.cloudera.org:8080/#/c/23546/3/be/src/scheduling/admission-control-service.cc@224 PS3, Line 224: discard_result(admission_state_map_.Delete(req->query_id())); > The admission_state_map_ is ShardedQueryPBMap, which is from GenericSharded I see that admission_state_lock is for admission state members and the sharded map has its own lock which protects concurrent operations on the map. So we shouldn't use admission_state_lock for operations on map. However, it is still possible for GetQueryStatus to update the admission state member while ReleaseQuery frees the admission state since these are protected by different locks. But, looks like we're fine here since we're using shared_ptr for admission state. -- To view, visit http://gerrit.cloudera.org:8080/23546 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1ba5e8818336bd1fc3ad604a0acee5eb7a1116c4 Gerrit-Change-Number: 23546 Gerrit-PatchSet: 3 Gerrit-Owner: Yida Wu <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Wed, 22 Oct 2025 13:39:56 +0000 Gerrit-HasComments: Yes
