Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/23546 )
Change subject: IMPALA-10204: Make AdmitQuery params more efficient ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/23546/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23546/2//COMMIT_MSG@16 PS2, Line 16: This commit introduces two optimizations for reducing the > Do you have any measurements of how much it reduces the memory footprint? During some tpcds run, without the change, the peak memory usage in admissiond was around 2GB, with the change, it would require lower than half the memory. Added this result to the commit message. http://gerrit.cloudera.org:8080/#/c/23546/2//COMMIT_MSG@29 PS2, Line 29: change > Did we run these tests with admissiond enabled? Yes, I think custom_cluster/test_admission_controller.py contains some AC enabled cases. http://gerrit.cloudera.org:8080/#/c/23546/2/be/src/service/client-request-state.cc File be/src/service/client-request-state.cc: http://gerrit.cloudera.org:8080/#/c/23546/2/be/src/service/client-request-state.cc@671 PS2, Line 671: // Use the swap() to ensure the string's memory is deallocated. > Why is this better than Added a comment in the code. -- To view, visit http://gerrit.cloudera.org:8080/23546 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1ba5e8818336bd1fc3ad604a0acee5eb7a1116c4 Gerrit-Change-Number: 23546 Gerrit-PatchSet: 3 Gerrit-Owner: Yida Wu <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Wed, 15 Oct 2025 19:01:53 +0000 Gerrit-HasComments: Yes
