Yida Wu has uploaded this change for review. ( http://gerrit.cloudera.org:8080/23546
Change subject: IMPALA-10204: Make AdmitQuery params more efficient ...................................................................... IMPALA-10204: Make AdmitQuery params more efficient The admission request may contain the lineage graphs and other stuff that the admission control service doesn't need. For example, currently the admission controller service would hold onto the full TQueryExecRequest object for the entire lifetime of a query, even after the admission decision was complete. This led to unnecessary memory consumption. This commit introduces two optimizations for reducing the memory footprint: 1. A lightweight copy of TQueryExecRequest is now created on the client side before sending to the admission control service. Fields that are not required for admission decisions (e.g., query_plan, lineage_graph) are cleared from this copy. 2. The AdmissionState now uses a unique_ptr to manage the TQueryExecRequest. This allows the object's memory to be explicitly released as soon as the query schedule is generated and the request object is no longer needed. Tests: Passed exhaustive tests. Change-Id: I1ba5e8818336bd1fc3ad604a0acee5eb7a1116c4 --- M be/src/scheduling/admission-control-service.cc M be/src/scheduling/admission-control-service.h M be/src/service/client-request-state.cc 3 files changed, 38 insertions(+), 5 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/46/23546/1 -- To view, visit http://gerrit.cloudera.org:8080/23546 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I1ba5e8818336bd1fc3ad604a0acee5eb7a1116c4 Gerrit-Change-Number: 23546 Gerrit-PatchSet: 1 Gerrit-Owner: Yida Wu <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]>
