Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/23346 )
Change subject: IMPALA-14330: set a valid createEventId in global INVALIDATE METADATA ...................................................................... Patch Set 5: (4 comments) http://gerrit.cloudera.org:8080/#/c/23346/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23346/3//COMMIT_MSG@52 PS3, Line 52: hits IMPALA-9135 and hangs, it needs catalogd to send new catalog > grammar: it needs catalogd to send Done http://gerrit.cloudera.org:8080/#/c/23346/3//COMMIT_MSG@53 PS3, Line 53: updates to reach the max waiting attempts (see waitForSyncDdlVersion()). > typo: attempts Done http://gerrit.cloudera.org:8080/#/c/23346/3/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/23346/3/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@5877 PS3, Line 5877: } > Is there some reason to do this here? It would make more sense at line 5910 The original code updates DeleteEventLog and createEventId together using this event id. I just split them so leave this here. I think we want to set the createEventId right after the table object is created in catalog. Moved this into CatalogServiceCatalog.renameTable(). http://gerrit.cloudera.org:8080/#/c/23346/3/tests/custom_cluster/test_concurrent_ddls.py File tests/custom_cluster/test_concurrent_ddls.py: http://gerrit.cloudera.org:8080/#/c/23346/3/tests/custom_cluster/test_concurrent_ddls.py@186 PS3, Line 186: tls.client.execute("create table {}.tmp_tbl{} (i int)".format(db, i)) > Could this cause dropping the database to take a long time? Is there some w The test usually runs in 20s (not counting the cleanup step) so only one or two tables are created. The majority of the tables are created by the 17 threads running run_ddls(), i.e. 34 tables created by them. -- To view, visit http://gerrit.cloudera.org:8080/23346 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6506821dedf7701cdfa58d14cae5760ee178c4ec Gerrit-Change-Number: 23346 Gerrit-PatchSet: 5 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Fri, 29 Aug 2025 01:53:57 +0000 Gerrit-HasComments: Yes
